postgresql-tenant-operator/internal/instance/service_test.go

/*
Copyright 2026.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package instance

import (
	"context"
	"errors"
	"fmt"
	"strings"
	"testing"

	api "git.ddupan.top/panxiao81/postgresql-tenant-operator/api/v1alpha1"
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

type sourceStub struct {
	reads int
	err   error
}

func (s *sourceStub) Read(context.Context, api.OpenBaoSecretReference) (Credentials, error) {
	s.reads++
	return Credentials{Username: "admin", Password: "canary-secret"}, s.err
}

type databaseStub struct {
	closes, migrations int
	err                error
}

func (d *databaseStub) Version(context.Context) (string, error) { return "17", d.err }
func (d *databaseStub) EnsureRegistry(context.Context) error    { d.migrations++; return d.err }
func (d *databaseStub) Close()                                  { d.closes++ }

type connectorStub struct {
	databases []*databaseStub
	err       error
}

func (c *connectorStub) Connect(context.Context, api.PostgreSQLEndpoint, Credentials) (Database, error) {
	if c.err != nil {
		return nil, c.err
	}
	database := &databaseStub{}
	c.databases = append(c.databases, database)
	return database, nil
}

func TestInstanceConnectionLifetime(t *testing.T) {
	source, connector := &sourceStub{}, &connectorStub{}
	service := NewService(source, connector)
	defer service.Close()
	resource := &api.PostgreSQLInstance{ObjectMeta: metav1.ObjectMeta{Name: "shared", UID: "uid-1"}}
	ctx := context.Background()
	check := func() {
		t.Helper()
		if _, err := service.Validate(ctx, resource); err != nil {
			t.Fatalf("validate: %v", err)
		}
	}
	check()
	if _, err := service.InitializeRegistry(ctx, resource); err != nil {
		t.Fatal(err)
	}
	resource.Generation++
	resource.Spec.AllowedExtensions = []string{"pg_trgm"}
	check()
	if source.reads != 1 || len(connector.databases) != 1 || connector.databases[0].migrations != 1 {
		t.Fatal("reconciliation or allowlist update unnecessarily reassembled dependencies")
	}
	connector.databases[0].err = errors.New("network outage")
	if _, err := service.Validate(ctx, resource); err == nil {
		t.Fatal("outage went unnoticed")
	}
	connector.databases[0].err = nil
	check()
	if source.reads != 1 {
		t.Fatal("network recovery reread the password")
	}

	changes := []func(){
		func() { resource.Spec.Endpoint.Host = "new.example" },
		func() { resource.Spec.AdminCredentialRef.Path = "new/admin" },
		func() { resource.UID = "uid-2" },
	}
	for index, change := range changes {
		change()
		check()
		if connector.databases[index].closes != 1 {
			t.Fatal("replaced pool was not closed")
		}
	}
	if source.reads != 4 {
		t.Fatal("changed connection identity did not reload credentials")
	}
	service.Forget(resource.Name)
	service.Forget(resource.Name)
	if connector.databases[3].closes != 1 {
		t.Fatal("deletion did not close pool exactly once")
	}
	check()
	service.Close()
	service.Close()
	if connector.databases[4].closes != 1 {
		t.Fatal("shutdown did not close pool exactly once")
	}
	if _, err := service.Validate(ctx, resource); err == nil {
		t.Fatal("closed service accepted work")
	}
}

func TestAssemblyRetriesWithoutPasswordRotation(t *testing.T) {
	source := &sourceStub{err: errors.New("bao unavailable")}
	connector := &connectorStub{err: errors.New("connection unavailable")}
	service := NewService(source, connector)
	defer service.Close()
	resource := &api.PostgreSQLInstance{ObjectMeta: metav1.ObjectMeta{Name: "shared"}}
	ctx := context.Background()
	if _, err := service.Validate(ctx, resource); err == nil {
		t.Fatal("expected source failure")
	}
	source.err = nil
	if _, err := service.Validate(ctx, resource); err == nil {
		t.Fatal("expected connection failure")
	}
	connector.err = nil
	if _, err := service.Validate(ctx, resource); err != nil {
		t.Fatal(err)
	}
	if source.reads != 2 {
		t.Fatal("retry reread successfully cached credentials")
	}
}

func TestCredentialsFormattingIsRedacted(t *testing.T) {
	value := Credentials{Username: "canary-user", Password: "canary-secret"}
	for _, format := range []string{"%v", "%+v", "%#v"} {
		if strings.Contains(fmt.Sprintf(format, value), "canary") {
			t.Fatal("credential formatting leaked data")
		}
	}
}