refactor: introduce Instance connection lifecycle service
This commit is contained in:
@@ -0,0 +1,152 @@
|
||||
/*
|
||||
Copyright 2026.
|
||||
|
||||
Licensed under the Apache License, Version 2.0 (the "License");
|
||||
you may not use this file except in compliance with the License.
|
||||
You may obtain a copy of the License at
|
||||
|
||||
http://www.apache.org/licenses/LICENSE-2.0
|
||||
|
||||
Unless required by applicable law or agreed to in writing, software
|
||||
distributed under the License is distributed on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
See the License for the specific language governing permissions and
|
||||
limitations under the License.
|
||||
*/
|
||||
|
||||
// Package instance manages the lifetime and capabilities of external PostgreSQL instances.
|
||||
package instance
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"sync"
|
||||
|
||||
api "git.ddupan.top/panxiao81/postgresql-tenant-operator/api/v1alpha1"
|
||||
"k8s.io/apimachinery/pkg/types"
|
||||
)
|
||||
|
||||
// Credentials are supplied by the credential source, never by the database adapter.
|
||||
type Credentials struct{ Username, Password string }
|
||||
|
||||
func (Credentials) String() string { return "[redacted credentials]" }
|
||||
func (Credentials) GoString() string { return "[redacted credentials]" }
|
||||
|
||||
// CredentialSource resolves administrative credentials when an Instance is assembled.
|
||||
type CredentialSource interface {
|
||||
Read(context.Context, api.OpenBaoSecretReference) (Credentials, error)
|
||||
}
|
||||
|
||||
// Database exposes the capabilities of an assembled Instance.
|
||||
type Database interface {
|
||||
Version(context.Context) (string, error)
|
||||
EnsureRegistry(context.Context) error
|
||||
Close()
|
||||
}
|
||||
|
||||
// Connector creates a database without knowing where credentials came from.
|
||||
type Connector interface {
|
||||
Connect(context.Context, api.PostgreSQLEndpoint, Credentials) (Database, error)
|
||||
}
|
||||
|
||||
type identity struct {
|
||||
uid types.UID
|
||||
endpoint api.PostgreSQLEndpoint
|
||||
reference api.OpenBaoSecretReference
|
||||
}
|
||||
|
||||
type entry struct {
|
||||
identity identity
|
||||
credentials *Credentials
|
||||
database Database
|
||||
}
|
||||
|
||||
// Service owns Instance connections. Reconciles reuse credentials and pools until
|
||||
// the UID, endpoint or credential reference changes; allowlist changes do not rotate them.
|
||||
// Operations are serialized to prevent Close racing with an active database operation.
|
||||
type Service struct {
|
||||
mu sync.Mutex
|
||||
source CredentialSource
|
||||
connector Connector
|
||||
entries map[string]*entry
|
||||
closed bool
|
||||
}
|
||||
|
||||
func NewService(source CredentialSource, connector Connector) *Service {
|
||||
return &Service{source: source, connector: connector, entries: make(map[string]*entry)}
|
||||
}
|
||||
|
||||
func (s *Service) Validate(ctx context.Context, resource *api.PostgreSQLInstance) (string, error) {
|
||||
return s.observe(ctx, resource, false)
|
||||
}
|
||||
|
||||
func (s *Service) InitializeRegistry(ctx context.Context, resource *api.PostgreSQLInstance) (string, error) {
|
||||
return s.observe(ctx, resource, true)
|
||||
}
|
||||
|
||||
func (s *Service) observe(ctx context.Context, resource *api.PostgreSQLInstance, ensureRegistry bool) (string, error) {
|
||||
s.mu.Lock()
|
||||
defer s.mu.Unlock()
|
||||
if s.closed {
|
||||
return "", errors.New("instance service is closed")
|
||||
}
|
||||
db, err := s.database(ctx, resource)
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
if ensureRegistry {
|
||||
if err := db.EnsureRegistry(ctx); err != nil {
|
||||
return "", err
|
||||
}
|
||||
}
|
||||
return db.Version(ctx)
|
||||
}
|
||||
|
||||
func (s *Service) database(ctx context.Context, resource *api.PostgreSQLInstance) (Database, error) {
|
||||
key := identity{uid: resource.UID, endpoint: resource.Spec.Endpoint, reference: resource.Spec.AdminCredentialRef}
|
||||
current := s.entries[resource.Name]
|
||||
if current == nil || current.identity != key {
|
||||
s.release(resource.Name)
|
||||
current = &entry{identity: key}
|
||||
s.entries[resource.Name] = current
|
||||
}
|
||||
if current.credentials == nil {
|
||||
credentials, err := s.source.Read(ctx, key.reference)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
current.credentials = &credentials
|
||||
}
|
||||
if current.database == nil {
|
||||
database, err := s.connector.Connect(ctx, key.endpoint, *current.credentials)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
current.database = database
|
||||
}
|
||||
return current.database, nil
|
||||
}
|
||||
|
||||
// Forget releases local resources only. It never deletes the external registry.
|
||||
func (s *Service) Forget(name string) {
|
||||
s.mu.Lock()
|
||||
defer s.mu.Unlock()
|
||||
s.release(name)
|
||||
}
|
||||
|
||||
func (s *Service) release(name string) {
|
||||
if current := s.entries[name]; current != nil && current.database != nil {
|
||||
current.database.Close()
|
||||
}
|
||||
delete(s.entries, name)
|
||||
}
|
||||
|
||||
// Close is called after manager workers stop, and is safe to repeat.
|
||||
func (s *Service) Close() {
|
||||
s.mu.Lock()
|
||||
defer s.mu.Unlock()
|
||||
s.closed = true
|
||||
for name := range s.entries {
|
||||
s.release(name)
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user