feat: add Instance identity and revision value objects

internal/domain/instance/credential_reference.go

@@ -36,8 +36,8 @@ type CredentialReference struct {
 	values CredentialReferenceValues
 }
 
-// Secret names follow the Kubernetes DNS subdomain syntax and 253-character limit.
-var secretName = regexp.MustCompile(`^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$`)
+// Instance and Secret names share the DNS subdomain syntax and 253-character limit.
+var dnsSubdomainName = regexp.MustCompile(`^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$`)
 
 func NewCredentialReference(values CredentialReferenceValues) (CredentialReference, error) {
 	reference := CredentialReference{values: values}
@@ -54,7 +54,7 @@ func (r CredentialReference) Values() CredentialReferenceValues { return r.value
 // Checking that the referenced Secret contains nonempty credentials is an application
 // responsibility. Errors omit input values and no implicit defaults are applied.
 func (r CredentialReference) Validate() error {
-	if len(r.values.Name) > 253 || !secretName.MatchString(r.values.Name) {
+	if len(r.values.Name) > 253 || !dnsSubdomainName.MatchString(r.values.Name) {
 		return errors.New("management Secret name must be a valid DNS subdomain of at most 253 characters")
 	}
 	if r.values.UsernameKey == "" {