From bfeb217558c2554d3d5c26d8ff5119a689f6da48 Mon Sep 17 00:00:00 2001 From: Kevin Fox Date: Fri, 10 Mar 2023 06:15:37 -0800 Subject: [PATCH] Fix cluster role name uniqueness Adds namespace to the ClusterRole and ClusterRoleBinding so that it doesn't conflict when you have two instances of the chart, in different namespaces with the same release name. Signed-off-by: Kevin Fox --- charts/spire/charts/spire-server/templates/roles.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/spire/charts/spire-server/templates/roles.yaml b/charts/spire/charts/spire-server/templates/roles.yaml index a0b0f45..57de993 100644 --- a/charts/spire/charts/spire-server/templates/roles.yaml +++ b/charts/spire/charts/spire-server/templates/roles.yaml @@ -66,7 +66,7 @@ roleRef: kind: ClusterRole apiVersion: rbac.authorization.k8s.io/v1 metadata: - name: {{ include "spire-server.fullname" . }} + name: {{ .Release.Namespace}}-{{ include "spire-server.fullname" . }} rules: - apiGroups: [authentication.k8s.io] resources: [tokenreviews] @@ -85,13 +85,13 @@ rules: kind: ClusterRoleBinding apiVersion: rbac.authorization.k8s.io/v1 metadata: - name: {{ include "spire-server.fullname" . }} + name: {{ .Release.Namespace}}-{{ include "spire-server.fullname" . }} subjects: - kind: ServiceAccount name: {{ include "spire-server.serviceAccountName" . }} namespace: {{ .Release.Namespace }} roleRef: kind: ClusterRole - name: {{ include "spire-server.fullname" . }} + name: {{ .Release.Namespace}}-{{ include "spire-server.fullname" . }} apiGroup: rbac.authorization.k8s.io {{- end }}