panxiao81/helm-charts-hardened
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(spire-server): add terminationGracePeriodSeconds (#835)

Browse Source 
* feat(spire-server): add terminationGracePeriodSeconds and lifecycle support

Adds two new top-level values to the spire-server chart:

- `terminationGracePeriodSeconds` (nullable, pod-spec level): overrides the
  default 30s termination grace period. Useful when the server is behind a
  load balancer that needs time to deregister the target (e.g. AWS NLB with
  a deregistration delay > 30s).

- `lifecycle` (object, container level): lifecycle hooks for the spire-server
  container. The primary use case is a preStop hook to hold the pod alive
  while the load balancer deregisters the target before SIGTERM is sent:

  lifecycle:
    preStop:
      sleep:
        seconds: 60

Both fields default to their absent/empty equivalents (null and {}) so
existing deployments are unaffected.

Signed-off-by: Bronson Mirafuentes <[email protected]>

* Bump docker/login-action from 4.1.0 to 4.2.0 (#836)

Bumps [docker/login-action](https://github.com/docker/login-action) from 4.1.0 to 4.2.0.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](https://github.com/docker/login-action/compare/v4.1.0...v4.2.0)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-version: 4.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Bronson Mirafuentes <[email protected]>

* feat(spire-server): remove lifecycle hook support

Lifecycle hooks are not needed for the terminationGracePeriodSeconds
use case; preStop semantics can be handled outside the chart.

Signed-off-by: Bronson Mirafuentes <[email protected]>

* update README

Signed-off-by: Bronson Mirafuentes <[email protected]>

* update README

Signed-off-by: Bronson Mirafuentes <[email protected]>

---------

Signed-off-by: Bronson Mirafuentes <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This commit is contained in:
Bronson Mirafuentes
2026-06-11 12:12:33 -07:00
committed by GitHub
co-authored by dependabot[bot]
parent 734aa653c2
commit 86c60b186f
3 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
charts/spire/charts/spire-server/README.md
+1
View File
@@ -116,6 +116,7 @@ In order to run Tornjak with simple HTTP Connection only, make sure you don't cr
| `tolerations` | List of tolerations | `[]` | | `tolerations` | List of tolerations | `[]` |
| `affinity` | List of node affinities | `{}` | | `affinity` | List of node affinities | `{}` |
| `topologySpreadConstraints` | Topology spread constraints for resilience | `[]` | | `topologySpreadConstraints` | Topology spread constraints for resilience | `[]` |
| `terminationGracePeriodSeconds` | Override the termination grace period for the pod. Increase to allow time for load balancer target deregistration and in-flight gRPC drain before SIGKILL. | `nil` |
| `livenessProbe.failureThreshold` | Failure threshold count for livenessProbe | `2` | | `livenessProbe.failureThreshold` | Failure threshold count for livenessProbe | `2` |
| `livenessProbe.initialDelaySeconds` | Initial delay seconds for livenessProbe | `15` | | `livenessProbe.initialDelaySeconds` | Initial delay seconds for livenessProbe | `15` |
| `livenessProbe.periodSeconds` | Period seconds for livenessProbe | `60` | | `livenessProbe.periodSeconds` | Period seconds for livenessProbe | `60` |
charts/spire/charts/spire-server/templates/server-resource.yaml
+3
View File
@@ -528,6 +528,9 @@ spec:
topologySpreadConstraints: topologySpreadConstraints:
{{- toYaml . | nindent 8 }} {{- toYaml . | nindent 8 }}
{{- end }} {{- end }}
{{- if .Values.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
volumes: volumes:
- name: server-tmp - name: server-tmp
emptyDir: {} emptyDir: {}
charts/spire/charts/spire-server/values.yaml
+3
View File
@@ -126,6 +126,9 @@ affinity: {}
## @param topologySpreadConstraints [array] Topology spread constraints for resilience ## @param topologySpreadConstraints [array] Topology spread constraints for resilience
topologySpreadConstraints: [] topologySpreadConstraints: []
## @param terminationGracePeriodSeconds [nullable] Override the termination grace period for the pod. Increase to allow time for load balancer target deregistration and in-flight gRPC drain before SIGKILL.
terminationGracePeriodSeconds: ~
## @param livenessProbe.failureThreshold Failure threshold count for livenessProbe ## @param livenessProbe.failureThreshold Failure threshold count for livenessProbe
## @param livenessProbe.initialDelaySeconds Initial delay seconds for livenessProbe ## @param livenessProbe.initialDelaySeconds Initial delay seconds for livenessProbe
## @param livenessProbe.periodSeconds Period seconds for livenessProbe ## @param livenessProbe.periodSeconds Period seconds for livenessProbe