From 152453731836120c3479813df6d6b5c139f58ec5 Mon Sep 17 00:00:00 2001 From: kfox1111 Date: Tue, 12 Dec 2023 08:14:16 -0800 Subject: [PATCH] Update default for additionalDomains not to include localhost (#146) Its pretty much only useful if you want to port forward the discovery provider and use localhost to access it. An uncommon use case. Its easy to add back for that case. This simplifies production deploymnet. Signed-off-by: Kevin Fox --- .../spire/charts/spiffe-oidc-discovery-provider/values.yaml | 4 ++-- examples/production/values.yaml | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/charts/spire/charts/spiffe-oidc-discovery-provider/values.yaml b/charts/spire/charts/spiffe-oidc-discovery-provider/values.yaml index 05907c3..f543dbe 100644 --- a/charts/spire/charts/spiffe-oidc-discovery-provider/values.yaml +++ b/charts/spire/charts/spiffe-oidc-discovery-provider/values.yaml @@ -132,8 +132,8 @@ config: ## @param config.logLevel The log level, valid values are "debug", "info", "warn", and "error" logLevel: info ## @param config.additionalDomains [array] Add additional domains that can be used for oidc discovery - additionalDomains: - - localhost + additionalDomains: [] + # - localhost acme: ## @param config.acme.tosAccepted Flag for Terms of Service acceptance diff --git a/examples/production/values.yaml b/examples/production/values.yaml index 814b5bb..4868ae7 100644 --- a/examples/production/values.yaml +++ b/examples/production/values.yaml @@ -94,8 +94,6 @@ upstream-spire-agent: spiffe-oidc-discovery-provider: enabled: true - config: - additionalDomains: [] insecureScheme: enabled: true podSecurityContext: