refactor: separate workload class from placement driver

internal/runnerbootstrap/bootstrap.go

@@ -13,12 +13,13 @@ import (
 )
 
 const (
-	EnvAssignmentID = "CI_ASSIGNMENT_ID"
-	EnvCapability   = "CI_RUNNER_CAPABILITY"
-	EnvFacadeURL    = "CI_RUNNER_FACADE_URL"
-	EnvFacadeID     = "CI_RUNNER_FACADE_SPIFFE_ID"
-	EnvSPIFFEID     = "CI_SPIFFE_ID"
-	EnvBackend      = "CI_RUNNER_BACKEND"
+	EnvAssignmentID  = "CI_ASSIGNMENT_ID"
+	EnvCapability    = "CI_RUNNER_CAPABILITY"
+	EnvFacadeURL     = "CI_RUNNER_FACADE_URL"
+	EnvFacadeID      = "CI_RUNNER_FACADE_SPIFFE_ID"
+	EnvSPIFFEID      = "CI_SPIFFE_ID"
+	EnvWorkloadClass = "CI_WORKLOAD_CLASS"
+	EnvDriver        = "CI_WORKLOAD_DRIVER"
 )
 
 // Bootstrap emits assignment-scoped launch configuration. FacadeURL is the
@@ -48,7 +49,8 @@ func (b Bootstrap) Environment(assignment taskassignment.Assignment) (map[string
 		EnvFacadeURL:             b.FacadeURL,
 		EnvFacadeID:              b.FacadeSPIFFEID,
 		EnvSPIFFEID:              assignment.Identity.SPIFFEID,
-		EnvBackend:               string(assignment.Backend),
+		EnvWorkloadClass:         string(assignment.Placement.Class),
+		EnvDriver:                string(assignment.Placement.Driver),
 		"SPIFFE_ENDPOINT_SOCKET": b.WorkloadAPIAddr,
 	}, nil
 }
@@ -67,7 +69,7 @@ type Registration struct {
 	Ephemeral bool     `json:"ephemeral"`
 }
 
-func RegistrationJSON(assignmentID, capability, localProxyURL string, backend taskassignment.Backend) ([]byte, error) {
+func RegistrationJSON(assignmentID, capability, localProxyURL string, placement taskassignment.Placement) ([]byte, error) {
 	if assignmentID == "" || capability == "" {
 		return nil, errors.New("assignment ID and runner capability are required")
 	}
@@ -75,13 +77,13 @@ func RegistrationJSON(assignmentID, capability, localProxyURL string, backend ta
 	if err != nil || parsed.Scheme != "http" || parsed.Host == "" {
 		return nil, errors.New("local runner proxy URL must be an absolute http URL")
 	}
-	if backend != taskassignment.BackendPod && backend != taskassignment.BackendVM {
-		return nil, fmt.Errorf("unsupported runner backend %q", backend)
+	if err := placement.Validate(); err != nil {
+		return nil, err
 	}
 	registration := Registration{
 		Warning: "Generated for one preassigned task by gitea-dynamic-runner.",
 		UUID:    assignmentID, Name: assignmentID, Token: capability,
-		Address: localProxyURL, Labels: []string{"self-hosted", string(backend)}, Ephemeral: true,
+		Address: localProxyURL, Labels: []string{"self-hosted", string(placement.Class), string(placement.Driver)}, Ephemeral: true,
 	}
 	data, err := json.MarshalIndent(registration, "", "  ")
 	if err != nil {

internal/runnerbootstrap/bootstrap_test.go

@@ -25,7 +25,7 @@ func testBootstrap(t *testing.T) Bootstrap {
 
 func testAssignment() taskassignment.Assignment {
 	return taskassignment.Assignment{
-		ID: "gitea-task-42", Backend: taskassignment.BackendPod,
+		ID: "gitea-task-42", Placement: taskassignment.KubernetesContainer,
 		Identity: taskidentity.Identity{SPIFFEID: "spiffe://ddupan.top/ci/owner/repo/publish"},
 	}
 }
@@ -46,7 +46,7 @@ func TestEnvironmentIsDeterministicAndAssignmentScoped(t *testing.T) {
 	if first[EnvAssignmentID] != "gitea-task-42" || first[EnvSPIFFEID] != testAssignment().Identity.SPIFFEID {
 		t.Fatalf("environment = %#v", first)
 	}
-	if first[EnvBackend] != "pod" || first[EnvFacadeID] == "" {
+	if first[EnvWorkloadClass] != "container" || first[EnvDriver] != "kubernetes" || first[EnvFacadeID] == "" {
 		t.Fatalf("environment = %#v", first)
 	}
 	if first["SPIFFE_ENDPOINT_SOCKET"] != "unix:///run/spire/agent-sockets/spire-agent.sock" {
@@ -55,7 +55,7 @@ func TestEnvironmentIsDeterministicAndAssignmentScoped(t *testing.T) {
 }
 
 func TestRegistrationMatchesOfficialRunnerSchema(t *testing.T) {
-	data, err := RegistrationJSON("gitea-task-42", "capability", "http://127.0.0.1:8080", taskassignment.BackendVM)
+	data, err := RegistrationJSON("gitea-task-42", "capability", "http://127.0.0.1:8080", taskassignment.OpenSandboxVM)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -66,13 +66,13 @@ func TestRegistrationMatchesOfficialRunnerSchema(t *testing.T) {
 	if registration.UUID != "gitea-task-42" || registration.Token != "capability" || registration.Address != "http://127.0.0.1:8080" || !registration.Ephemeral {
 		t.Fatalf("registration = %#v", registration)
 	}
-	if len(registration.Labels) != 2 || registration.Labels[0] != "self-hosted" || registration.Labels[1] != "vm" {
+	if len(registration.Labels) != 3 || registration.Labels[0] != "self-hosted" || registration.Labels[1] != "vm" || registration.Labels[2] != "opensandbox" {
 		t.Fatalf("labels = %#v", registration.Labels)
 	}
 }
 
 func TestRegistrationRejectsNonLocalTLSAddress(t *testing.T) {
-	if _, err := RegistrationJSON("id", "capability", "https://facade.example", taskassignment.BackendPod); err == nil {
+	if _, err := RegistrationJSON("id", "capability", "https://facade.example", taskassignment.KubernetesContainer); err == nil {
 		t.Fatal("expected local proxy URL validation error")
 	}
 }

internal/runnerbootstrap/executor.go

@@ -17,7 +17,7 @@ import (
 type ExecutorConfig struct {
 	AssignmentID    string
 	Capability      string
-	Backend         taskassignment.Backend
+	Placement       taskassignment.Placement
 	FacadeURL       string
 	FacadeSPIFFEID  string
 	WorkloadAPIAddr string
@@ -71,7 +71,7 @@ func RunExecutor(ctx context.Context, config ExecutorConfig) error {
 		defer os.RemoveAll(workDir)
 	}
 	registration, err := RegistrationJSON(
-		config.AssignmentID, config.Capability, "http://"+listener.Addr().String(), config.Backend,
+		config.AssignmentID, config.Capability, "http://"+listener.Addr().String(), config.Placement,
 	)
 	if err != nil {
 		return err
@@ -144,13 +144,13 @@ func waitForFacade(ctx context.Context, endpoint string) error {
 // the assignment-scoped values injected by the backend. The Workload API
 // address follows SPIFFE_ENDPOINT_SOCKET through go-spiffe when not set here.
 func ExecutorConfigFromEnvironment() (ExecutorConfig, error) {
-	backend := taskassignment.Backend(os.Getenv(EnvBackend))
-	if backend != taskassignment.BackendPod && backend != taskassignment.BackendVM {
-		return ExecutorConfig{}, fmt.Errorf("invalid %s %q", EnvBackend, backend)
+	placement := taskassignment.Placement{Class: taskassignment.WorkloadClass(os.Getenv(EnvWorkloadClass)), Driver: taskassignment.Driver(os.Getenv(EnvDriver))}
+	if err := placement.Validate(); err != nil {
+		return ExecutorConfig{}, err
 	}
 	config := ExecutorConfig{
 		AssignmentID: os.Getenv(EnvAssignmentID), Capability: os.Getenv(EnvCapability),
-		Backend: backend, FacadeURL: os.Getenv(EnvFacadeURL), FacadeSPIFFEID: os.Getenv(EnvFacadeID),
+		Placement: placement, FacadeURL: os.Getenv(EnvFacadeURL), FacadeSPIFFEID: os.Getenv(EnvFacadeID),
 		RunnerBinary: os.Getenv("GITEA_RUNNER_BINARY"), RunnerConfig: os.Getenv("GITEA_RUNNER_CONFIG_FILE"),
 		ListenAddress: "127.0.0.1:0",
 		Stdout:        os.Stdout, Stderr: os.Stderr,